test: integration test for finalizer adding without SSA#3487
Open
csviri wants to merge 1 commit into
Open
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a focused integration test in operator-framework to verify that the framework can add (and later remove) a reconciler finalizer when Server-Side Apply (SSA) is disabled for primary-resource patching.
Changes:
- Introduces a new
Cleaner-implementing reconciler used to exercise finalizer behavior with SSA disabled. - Adds an integration test that creates and deletes a custom resource, asserting finalizer addition and successful cleanup/deletion.
- Adds a minimal custom resource type used exclusively by the new test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/finalizernossa/AddFinalizerNoSSAReconciler.java | New test reconciler implementing Cleaner to trigger framework-managed finalizer behavior without SSA. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/finalizernossa/AddFinalizerNoSSAIT.java | New IT validating finalizer add/remove and cleanup path when SSA is disabled. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/finalizernossa/AddFinalizerNoSSACustomResource.java | New minimal CR type used by the non-SSA finalizer integration test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration test for adding finalizer without Server Side Apply.
Signed-off-by: Attila Mészáros a_meszaros@apple.com