Address review feedback from PRs #14 and #16

[tmshort]

Summary

Addresses all inline review comments from @perdasilva on the merged stack PRs.

Changes

catalog.go

• Move FBC schema strings ("olm.package", "olm.bundle", "olm.channel") to named constants fbcSchemaPackage, fbcSchemaBundle, fbcSchemaChannel

collector.go

• Add ClusterServiceVersion, Subscription, InstallPlan to olmv0OnlyKinds so all OLMv0 management resources are excluded in one place
• Remove redundant local skipKinds map in gatherResourcesFromOperatorCR; use olmv0OnlyKinds directly
• Rename gatherResourcesByOwnerLabel param csvName → ownerName (addresses suggestion)
• Rename gatherResourcesByOwnerRef to take ownerName string instead of csv *ClusterServiceVersion; update ownerRef check and call site (addresses suggestion)
• Add comment explaining why Namespace is in possibleResourceGVKs (some operators create namespaces as bundle resources)
• Clarify deprecated status.install fallback with TODO comment

labels.go / migration.go

• Extract cosWaitPollInterval/Timeout, ceWaitPollInterval/Timeout, subWaitPollInterval/Timeout constants (addresses suggestion to move timeout/poll periods to constants)
• Add TODO for secretPacker exportability/configurability

scan.go

• Replace custom splitNamespacedName with strings.SplitN (renamed splitSubRef to be more specific)

compatibility.go

• Fix stale C3 comment — APIService is not supported in OLMv1 (permanent hard block); restore checkNoAPIServices and its call site

specs/20260821-migration-v0-to-v1/requirements.md + plan.md

• C3 updated to permanent hard block; OPRUN-4723 future-removal note removed

migrate-catalogs-v0-to-v1/main.go

• Move result status strings to named constants (statusCreated, statusAdopted, statusSkipped, statusError, statusDryRun)

convert.go

• Add TODO about progress channel to avoid step-by-step duplication of Migrate() logic

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: cacc8701-4646-401c-9da1-a8ced2de299f

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}