Skip to content

🌱 Update golang to 1.26#2743

Merged
openshift-merge-bot[bot] merged 3 commits into
operator-framework:mainfrom
rashmigottipati:update-go-version
Jun 5, 2026
Merged

🌱 Update golang to 1.26#2743
openshift-merge-bot[bot] merged 3 commits into
operator-framework:mainfrom
rashmigottipati:update-go-version

Conversation

@rashmigottipati
Copy link
Copy Markdown
Member

@rashmigottipati rashmigottipati commented Jun 4, 2026

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@rashmigottipati
Update golang to 1.26
95a3c6d 
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
Copilot AI review requested due to automatic review settings June 4, 2026 17:20
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 4, 2026 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 97c86da
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a21c63321a57000081ae8c7
😎 Deploy Preview https://deploy-preview-2743--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci Bot requested review from oceanc80 and tmshort June 4, 2026 17:20
@rashmigottipati
Copy link
Copy Markdown
Member Author

rashmigottipati commented Jun 4, 2026

/hold
Downstream PR that has the builder update needs to land first

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2026
Copilot AI reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the module’s Go language/toolchain requirement in go.mod, which in turn drives local development and CI tooling via actions/setup-go’s go-version-file usage across workflows.

Changes:

  • Bump go.mod go directive from 1.25.7 to 1.26.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.95%. Comparing base (ff766f2) to head (97c86da).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2743      +/-   ##
==========================================
- Coverage   66.96%   66.95%   -0.02%     
==========================================
  Files         149      149              
  Lines       11341    11341              
==========================================
- Hits         7595     7593       -2     
- Misses       3190     3191       +1     
- Partials      556      557       +1
Flag Coverage Δ
e2e 35.20% <ø> (+0.02%) ⬆️
experimental-e2e 52.59% <ø> (+0.05%) ⬆️
unit 52.23% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rashmigottipati
Update go.mod files across all modules to use golang 1.26
b8329a5 
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Jun 4, 2026 •
edited
Loading

Need to add the override label and update the PR description.
We should wait for downstream PRs to be ready to accept this (i.e. the bumper)
You might need to specify an exact version; 1.26.3 is acceptable.

@rashmigottipati
update to go 1.26.3
97c86da 
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
Copilot AI review requested due to automatic review settings June 4, 2026 18:38
Copilot AI reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rashmigottipati rashmigottipati changed the title Update golang to 1.26 🌱 Update golang to 1.26 Jun 4, 2026
@rashmigottipati rashmigottipati added override-go-verdiff Override the go-verdiff test result. If this label is present the golang version has changed! go-verdiff-override and removed override-go-verdiff Override the go-verdiff test result. If this label is present the golang version has changed! labels Jun 4, 2026
@operator-framework operator-framework deleted a comment from openshift-ci Bot Jun 4, 2026
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Jun 4, 2026

You also need to re-run the go-verdiff.

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Jun 4, 2026

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2026
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Jun 5, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2026
@tmshort tmshort mentioned this pull request Jun 5, 2026
Open
4 tasks
@rashmigottipati
Copy link
Copy Markdown
Member Author

rashmigottipati commented Jun 5, 2026

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 68d8308 into operator-framework:main Jun 5, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@oceanc80 oceanc80 Awaiting requested review from oceanc80

@tmshort tmshort Awaiting requested review from tmshort

Assignees

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. go-verdiff-override lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rashmigottipati @tmshort