🐛 Update mockgen target to remove vendorlesspath fix #3726
Merged
+1
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
That's great! I tried to fix this issue in #3720. It's better to fix it in a separate PR here. |
anik120
reviewed
Dec 16, 2025
Makefile
Outdated
Comment on lines
344
to
346
| # overlay_file=$$(mktemp "$(CURDIR)/hack/overlays/goimports_overlay.XXXXXX.json"); \ | ||
| # trap 'rm -f "$$overlay_file"' EXIT; \ | ||
| # printf '{\n "Replace": {\n "%s/vendor/golang.org/x/tools/imports/vendorlesspath.go": "%s/hack/overlays/goimports_vendorlesspath.go"\n }\n}\n' "$(CURDIR)" "$(CURDIR)" > "$$overlay_file"; \ |
Member
There was a problem hiding this comment.
Do we need to keep these lines around commented out?
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
fixup-verify
branch
from
08d036a to
9f27212
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, jianzhangbjz, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 58664cc
into
operator-framework:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adds manual fix removing the patch to include the VendorlessPath function that went missing a while back ref and addressed in #3670
Motivation for the change:
make verifyis brokenArchitectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue