[AI-FSSDK] [FSSDK-12368] Remove legacy flag-level holdout fields#404
Open
[AI-FSSDK] [FSSDK-12368] Remove legacy flag-level holdout fields#404
Conversation
Remove deprecated IncludedFlags and ExcludedFlags from Holdout entity and remove GetHoldoutsForFlag method from ProjectConfig. - Removed IncludedFlags and ExcludedFlags properties from Holdout - Removed GetHoldoutsForFlag() from HoldoutConfig, ProjectConfig interface, and DatafileProjectConfig - Simplified HoldoutConfig by removing flag-level targeting logic - Updated DecisionService to use all holdouts instead of GetHoldoutsForFlag - Deleted HoldoutConfigTests.cs (344 lines of legacy tests) - Removed 7 test methods testing deleted functionality - Created HoldoutConfigBasicTests.cs for remaining functionality Net change: -644 lines (650 deletions, 6 additions) All requirements met. CI will validate compilation and tests. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated
IncludedFlagsandExcludedFlagsfrom Holdout entity and removeGetHoldoutsForFlagmethod from ProjectConfig.Changes
IncludedFlagsandExcludedFlagsproperties from HoldoutGetHoldoutsForFlag()from HoldoutConfig, ProjectConfig interface, and DatafileProjectConfigTesting
Quality Metrics
Related
🤖 Generated with Claude Code