setup.ValidateHasContainerTags: support use in rootless containers #447
+19
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in a rootless container (made possible via osbuild/bootc-image-builder#1189) then generally the per-user container store is passed to bc-i-b, both because that makes sense, but also because the container doesn't have permissions to read the host store. This is typically done by passing
-v ~/.local/share/containers/storage:/var/lib/containers/storagewhen running bc-i-b in podman.Unfortunately when this happens, podman complains that the store is in the wrong place:
To fix this, we pass in podman arguments
--rootand--imagestoreto set up an environment where the graphroot is some empty directory that has the "correct" location and we only load the image layers from /var/lib/containers.To ensure this doesn't weirdly affect the regular case, this is all protected by podmanutil.IsRootless().