Conversation
…ble sync functionality to avoid confusing the user - add tooltip function to Action interface - remove aria-label when aria-label value is null so that it does not show in the html with empty value
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| tooltip: () => | ||
| $pgettext( | ||
| 'Explanation tooltip for the enable sync action in files shared with me and spaces', | ||
| 'Only affects desktop and mobile clients. You can toggle this setting here, but it will only take effect on those platforms.' |
There was a problem hiding this comment.
Best to check with @DeepDiver1975 whether mobile clients are really affected or if it's only desktop...
| tooltip: () => | ||
| $pgettext( | ||
| 'Explanation tooltip for the enable sync action in files shared with me and spaces', | ||
| 'Only affects desktop and mobile clients. You can toggle this setting here, but it will only take effect on those platforms.' |
There was a problem hiding this comment.
What would you say about being a bit more explicite what the settings actually do? Then maybe the mention that it does not affect web client might be redundant because it might be clear enough from the functionality description.
| /> | ||
| </oc-button> | ||
| <span :id="uniqueId" class="oc-invisible-sr"> | ||
| {{ tooltipText }} |
There was a problem hiding this comment.
Won't this result in the action label being read twice in case there is no custom tooltip?
|
|
||
| const tooltipText = computed<string>(() => { | ||
| if (action?.tooltip) { | ||
| return `${action.label(actionOptions)} - ${action.tooltip(actionOptions)}` |
There was a problem hiding this comment.
I wonder whether we need to include the action label here or if we can rely only on the tooltip...
|
2 participants
add explicit explanation to enable/disable sync functionality to avoid confusing the user
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: