Conversation
emilyalbini
force-pushed
the
ea-ci
branch
7 times, most recently
from
d157525 to
1995a55
Compare
jclulow
left a comment
jclulow
left a comment
There was a problem hiding this comment.
The bunch of the changes are fixes for Clippy. I ran a
cargo clippy --fix --teststo address most of them, and configured a global list of lints we allow in the workspaceCargo.toml(rather than adding#![allow()]in every crate).
The global lint list thing is neat! Can we do the clippy changes in a separate PR (first) and then do the CI stuff (which also looks broadly fine to start!) as a separate, smaller change after that?
.github/buildomat/test.sh
Outdated
| set -o xtrace | ||
|
|
||
| banner clippy | ||
| cargo clippy --tests --workspace -- -Dwarnings |
There was a problem hiding this comment.
Should we be passing the --frozen flag to all these commands as well?
There was a problem hiding this comment.
Added --locked, good call! --frozen also requires all crates to be downloaded first.
Yes! I'm so happy Cargo is slowly adding more workspace-wide configuration options! I split the clippy changes in #96. |
2 participants
This PR adds a basic CI to buildomat, checking formatting, clippy, and running tests. In the future we'll probably want to extend it to also build the production binaries we run on the buildomat server, but that's a task for another time.
The bunch of the changes are fixes for Clippy. I ran a
cargo clippy --fix --teststo address most of them, and configured a global list of lints we allow in the workspaceCargo.toml(rather than adding#![allow()]in every crate).