agent: separate request and response payload types#97
Open
emilyalbini wants to merge 1 commit intomainfrom
Open
agent: separate request and response payload types#97emilyalbini wants to merge 1 commit intomainfrom
emilyalbini wants to merge 1 commit intomainfrom
Conversation
emilyalbini
force-pushed
the
ea-refactor-payload
branch
from
20b00a3 to
ba2e5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the agent's
Payloadinto thePayloadReqandPayloadRespenums.I felt the need of this while working on the upcoming "cleanup tasks" (
bmat process on-success/bmat process on-failure): I added new payloads to let thebmatCLI communicate with the agents, and handled them in the agent main loop, but forgot to also allow the new payload to be proxied to the main loop. The resulting error message was cryptic to say the least:By separating requests and responses we can now match exhaustively on requests, getting compiler errors pointing in the right direction when adding new payloads.