Add a stable re-export surface and tests for external rack-init tooling - #11033
Open
sion42x wants to merge 2 commits into
Open
Add a stable re-export surface and tests for external rack-init tooling#11033sion42x wants to merge 2 commits into
sion42x wants to merge 2 commits into
Conversation
andrewjstone
approved these changes
Aug 9, 2026
| (0..3) | ||
| .map(|index| BaseboardId { | ||
| part_number: "913-0000019".to_string(), | ||
| serial_number: format!("BRM4222000{index}"), |
Contributor
There was a problem hiding this comment.
This should use the "2FAKE00{index}" format for consistency with everything else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External testing tools have either hand-maintained config-rss.toml or duplicated the request types, and both break silently when the format moves. This (tiny) crate re-exports everything a
RackInitializeRequestis built from and renders theconfig-rss.tomlsled-agent parses.The tests round-trip constructed requests and the in-tree non-gimlet example through sled-agent's
rack_initialize_request_from_file, giving us a CI-side test to catch breaking changes in different scenarios: