validate number of indirect desc in pop_avail - #1188
Open
Conversation
papertigers
changed the base branch from
spr/papertigers/master.validate-number-of-indirect-desc-in-pop_avail
to
spr/papertigers/bump-rust-to-1971
July 29, 2026 00:28
papertigers
changed the base branch from
spr/papertigers/bump-rust-to-1971
to
spr/papertigers/master.validate-number-of-indirect-desc-in-pop_avail
July 29, 2026 00:32
papertigers
commented
Jul 29, 2026
|
|
||
| if flags.contains(DescFlag::NEXT) { | ||
| if count == self.size() { | ||
| // XXX: signal error condition? |
Contributor
Author
There was a problem hiding this comment.
We need to address #1190 to properly solve this.
Currently return None and we also fail to return the descriptor to the used ring, this can leave the queue stalled or in an overall bad state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pop_availfunction now validates that the number of indirect descriptors is not larger than the size of the virtio queue.Stack: