add option to set ip address or host#54
Open
upgradingdave wants to merge 2 commits intopandeiro:masterfrom
upgradingdave:hostname
Open
add option to set ip address or host#54upgradingdave wants to merge 2 commits intopandeiro:masterfrom upgradingdave:hostname
upgradingdave wants to merge 2 commits intopandeiro:masterfrom
upgradingdave:hostname
Conversation
|
@upgradingdave I have tried your fix and it is working. But there is |
Author
|
Hi @drownbes, glad to hear it's working. I updated so the output reflects the ip address configured. If you notice any other issue, please let me know. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw a question on Slack about whether it's possible to set ip address that server binds to and so I threw this together quickly. This should work for jetty and http-kit. jetty uses the
:hostoption and http-kit uses the:ipoption. Feel free to merge if you think it'd be good option to provide. Otherwise, it might be better to take a step back and provide a more general way to pass options thru to the server impl (either to http-kit or jetty).