Skip to content

Back to sw#75

Open
swasilyev wants to merge 2 commits intomasterfrom
back-to-sw
Open

Back to sw#75
swasilyev wants to merge 2 commits intomasterfrom
back-to-sw

Conversation

@swasilyev
Copy link
Copy Markdown
Contributor

Pasta curves don't have edwards form, so I found and replaced:

use ark_ec::twisted_edwards::{Affine, TECurveConfig};
-> use ark_ec::short_weierstrass::{Affine, SWCurveConfig};

TECurveConfig -> SWCurveConfig

ark_ed_on_bls12_381_bandersnatch::EdwardsAffine
-> ark_ed_on_bls12_381_bandersnatch::SWAffine

The question is. Do we have to restore the TE implementation fr bandersnatch? I would assume that our proofs are short-lived, so we can upgrade carefully?

@swasilyev swasilyev requested review from davxy and drskalman April 9, 2026 11:55
Copy link
Copy Markdown
Member

@davxy davxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would invalidate several JAM-related components, which is not something we can take lightly.
This involves changes to the GP, fuzzing tools, published and established test vectors, and implementors racing for the JAM price.

I imagine that is possible for both approaches to coexist? IIRC there was a PR quite a while ago.
For Bandersnatch, we need to continue using TE for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants