Open
Conversation
davxy
requested changes
Apr 9, 2026
Member
There was a problem hiding this comment.
This change would invalidate several JAM-related components, which is not something we can take lightly.
This involves changes to the GP, fuzzing tools, published and established test vectors, and implementors racing for the JAM price.
I imagine that is possible for both approaches to coexist? IIRC there was a PR quite a while ago.
For Bandersnatch, we need to continue using TE for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasta curves don't have edwards form, so I found and replaced:
use ark_ec::twisted_edwards::{Affine, TECurveConfig};
-> use ark_ec::short_weierstrass::{Affine, SWCurveConfig};
TECurveConfig -> SWCurveConfig
ark_ed_on_bls12_381_bandersnatch::EdwardsAffine
-> ark_ed_on_bls12_381_bandersnatch::SWAffine
The question is. Do we have to restore the TE implementation fr bandersnatch? I would assume that our proofs are short-lived, so we can upgrade carefully?