feat(server): implement chain.getChainInfo in the core - #358
Draft
valentinfernandez1 wants to merge 6 commits into
Draft
feat(server): implement chain.getChainInfo in the core#358valentinfernandez1 wants to merge 6 commits into
valentinfernandez1 wants to merge 6 commits into
Conversation
Add the RFC document plus its protocol surface: chain.getSupportedChains (wire id 166) enumerates the chains a host serves as (name, network, genesisHash) descriptors, and chain.resolveChain (168) maps a (name, network) pair to its genesis hash or NotFound. Both trait methods are stubs returning unavailable, so products stop hard-coding genesis hashes once hosts implement the backing syscall in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #352, implements the wire surface from #354.
What
chain.getChainInfonow works end to end in the core. Hosts implement one callback,Features::supported_chains, returning aHostChainSet(the network string plus one genesis hash perChainIdentifierrole), and the core resolves each request against it inhost_logic/features.rs, echoing the identifier and mapping a miss toNotSupported.Verified end to end against the headless host CLI: a battery run with the CLI answering
supported_chainsfrom its paseo-next-v2 preset resolvedgetChainInfoover the real wire (Chain/get_chain_inforeported ✅), and the generated examples that resolve their genesis hashes through it kept their baseline results. That CLI chain set ships in a follow-up PR.