Skip to content

Use Pdo\Pgsql::getNotify if PHP version is >= 8.4 instead of PDO::pgsqlGetNotify.#828

Merged
DanielBadura merged 3 commits into3.19.xfrom
fix-deprecation-notice
Mar 9, 2026
Merged

Use Pdo\Pgsql::getNotify if PHP version is >= 8.4 instead of PDO::pgsqlGetNotify.#828
DanielBadura merged 3 commits into3.19.xfrom
fix-deprecation-notice

Conversation

@DanielBadura
Copy link
Member

fix #827

@DanielBadura DanielBadura requested a review from DavidBadura March 9, 2026 17:18
@DanielBadura DanielBadura self-assigned this Mar 9, 2026
@DanielBadura DanielBadura added the enhancement New feature or request label Mar 9, 2026
@DanielBadura
Copy link
Member Author

DanielBadura commented Mar 9, 2026

Huh, windows... Missing pdo_pgqsql extension for unit tests

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Hello 👋

here is the most recent benchmark result:

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.213ms (±0.00%)   | 1.027ms (±0.00%)   | +18.06%   | 35.582mb        | 36.098mb   | -1.43%      |
| benchLoad10000Events ()                | 93.896ms (±0.00%)  | 97.747ms (±0.00%)  | -3.94%    | 35.583mb        | 35.583mb   | 0.00%       |
| benchSave1Event ()                     | 1.867ms (±0.00%)   | 1.841ms (±0.00%)   | +1.41%    | 35.582mb        | 35.582mb   | 0.00%       |
| benchSave10000Events ()                | 265.561ms (±0.00%) | 271.339ms (±0.00%) | -2.13%    | 35.584mb        | 35.584mb   | 0.00%       |
| benchSave10000Aggregates ()            | 13.412s (±0.00%)   | 13.520s (±0.00%)   | -0.80%    | 35.583mb        | 35.583mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.766s (±0.00%)    | 9.767s (±0.00%)    | -0.01%    | 36.042mb        | 36.042mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                 | memory                                     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>   | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 2.791ms (±0.00%) | 2.696ms (±0.00%) | +3.52%    | 4.792mb         | 4.792mb    | 0.00%       |
| benchUpdate () | 4.168ms (±0.00%) | 4.297ms (±0.00%) | -2.99%    | 5.008mb         | 5.008mb    | 0.00%       |
| benchBoth ()   | 6.850ms (±0.00%) | 7.103ms (±0.00%) | -3.55%    | 4.978mb         | 4.978mb    | 0.00%       |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 63.891ms (±0.00%) | 64.799ms (±0.00%) | -1.40%    | 35.047mb        | 35.047mb   | 0.00%       |
| benchLoad10000Events ()                | 1.281ms (±0.00%)  | 1.277ms (±0.00%)  | +0.28%    | 35.047mb        | 35.047mb   | 0.00%       |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.079ms (±0.00%)   | 1.070ms (±0.00%)   | +0.81%    | 35.204mb        | 35.204mb   | 0.00%       |
| benchLoad10000Events ()                | 71.079ms (±0.00%)  | 67.966ms (±0.00%)  | +4.58%    | 35.204mb        | 35.204mb   | 0.00%       |
| benchSave1Event ()                     | 1.279ms (±0.00%)   | 1.231ms (±0.00%)   | +3.88%    | 35.204mb        | 35.204mb   | 0.00%       |
| benchSave10000Events ()                | 294.211ms (±0.00%) | 288.064ms (±0.00%) | +2.13%    | 35.204mb        | 35.204mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.914s (±0.00%)    | 8.889s (±0.00%)    | +0.27%    | 35.204mb        | 35.204mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.434s (±0.00%)    | 5.421s (±0.00%)    | +0.25%    | 35.204mb        | 35.204mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.114ms (±0.00%)   | 1.152ms (±0.00%)   | -3.29%    | 34.977mb        | 34.977mb   | 0.00%       |
| benchLoad10000Events ()                | 62.337ms (±0.00%)  | 61.980ms (±0.00%)  | +0.58%    | 34.977mb        | 34.977mb   | 0.00%       |
| benchSave1Event ()                     | 1.311ms (±0.00%)   | 1.562ms (±0.00%)   | -16.11%   | 34.977mb        | 34.977mb   | 0.00%       |
| benchSave10000Events ()                | 225.061ms (±0.00%) | 222.423ms (±0.00%) | +1.19%    | 34.977mb        | 34.977mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.820s (±0.00%)    | 8.854s (±0.00%)    | -0.39%    | 34.977mb        | 34.977mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.233s (±0.00%)    | 5.291s (±0.00%)    | -1.09%    | 34.977mb        | 34.977mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 83.987ms (±0.00%) | 82.867ms (±0.00%) | +1.35%    | 35.542mb        | 35.542mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 5.303ms (±0.00%)   | 5.628ms (±0.00%)   | -5.77%    | 35.582mb        | 35.582mb   | 0.00%       |
| benchSave10000Events () | 346.422ms (±0.00%) | 357.424ms (±0.00%) | -3.08%    | 35.649mb        | 35.649mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.431s (±0.00%) | 3.435s (±0.00%) | -0.12%    | 47.555mb        | 47.555mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura DanielBadura force-pushed the fix-deprecation-notice branch from 095437a to 333635c Compare March 9, 2026 17:36
@DavidBadura DavidBadura added this to the 3.19.0 milestone Mar 9, 2026
@DanielBadura DanielBadura merged commit 3dfb836 into 3.19.x Mar 9, 2026
49 of 77 checks passed
@DanielBadura DanielBadura deleted the fix-deprecation-notice branch March 9, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.5 deprecation: PDO::pgsqlGetNotify() in StreamDoctrineDbalStore

2 participants