Skip to content

Fix redundant .clone().clone() #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aritra0342 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix redundant .clone().clone() #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daebbfc
Fix redundant .clone().clone()
aritra0342 Mar 4, 2026
4486f2c
2. Improve error message formatting efficiency
aritra0342 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/connectors/data_format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ pub enum ParseError {
#[error("key-value pair has unexpected number of tokens: {0} instead of 2")]
KeyValueTokensIncorrect(usize),

#[error("field {field_name} with {} is absent in {payload}", path.clone().map_or("no JsonPointer path specified".to_string(), |path| format!("path {path}") ))]
#[error("field {field_name} with {} is absent in {payload}", path.as_ref().map_or("no JsonPointer path specified", |p| p.as_str())]
FailedToExtractJsonField {
field_name: String,
path: Option<String>,
Expand Down
2 changes: 1 addition & 1 deletion src/engine/dataflow/operators/time_column.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ fn push_key_values_to_output<K, C: Cursor, P>(
assert!(time >= *capability.time());
output.session(&capability).give((
(k.clone(), curr_val.clone()),
time.clone().clone(),
time.clone(),
weight,
));
}
Expand Down
Loading