Stop exceptions from breaking the watcher#170
Open
thewilkybarkid wants to merge 1 commit intopattern-lab:developfrom
Open
Stop exceptions from breaking the watcher#170thewilkybarkid wants to merge 1 commit intopattern-lab:developfrom
thewilkybarkid wants to merge 1 commit intopattern-lab:developfrom
Conversation
thewilkybarkid
force-pushed
the
watch-exception
branch
from
41c9c58 to
f54a1a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently hitting pattern-lab/patternengine-php-twig#34 (comment), where an invalid Twig template (possible while developing) breaks the watcher. Using
--no-procsreveals the exception and the terminated process, otherwise it silently fails (the watch process continues, but nothing happens).This catches any exception and outputs the message.