fix(ui): prevent text overlap in breadcrumbs #15040
Open
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rilrom
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Text overflow for breadcrumbs regressed during the modular dashboards implementation.
Why?
overflow: hiddenwas removed from breadcrumbs text, which breakstext-overflow: ellipsis.How?
Reintroduce
overflow: hiddento breadcrumbs text, while making an exception for the modular dashboard select/dropdown elements.I specifically opted for a more verbose scss solution (compared to using something like
span:not(:has())as I found it was easier to read.Fixes #15030