Open
Conversation
ghost
assigned
Contributor
There was a problem hiding this comment.
Coding style - should be 'if () {}', not if()
Author
There was a problem hiding this comment.
thx for reviewing. It seems as if I have not ran PHPCS over the files yet (WIP).
Will check CS of my commits later.
Contributor
|
LGTM at first glance - a few CS issues, and it's annoying about the MDB2 issues breaking the build... |
Member
|
@CloCkWeRX We got side-tracked with this at work. But I am guessing, we'll wrap this up in the next couple of weeks. |
Member
|
@CloCkWeRX If you know of a neat trick to make PEAR behave on travis, let me know. |
Contributor
|
Not really, apart from forking mdb2/ripping out the load extension code from it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@till feedback appreciated