Add support for watch-specific settings in localStorage #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellcp
reviewed
Jan 2, 2026
index.js
Outdated
| localStorage.setItem('clay-watch-' + this.meta.watchToken, | ||
| JSON.stringify(watchSpecificSettings)); | ||
| } | ||
| localStorage.setItem('clay-settings', JSON.stringify(settings)); |
Member
There was a problem hiding this comment.
Should all of these settings be persisted, or only the settings that aren't specific to the watch? It might be better to retain nothing over a setting from the last watch that was configured
Author
There was a problem hiding this comment.
I was in doubt myself. What is the behavior we want when a new watch is encountered.
The current implementation is closest to existing behavior, you inherit the last used settings. But falling back to the defaults would probably be better, also less risk of having an impossible setting based on capabilities (but this should always be verified on the watch side as well).
I'll make the changes.
Store each setting either in a watch specific setting or in a global setting. When no setting is stored for a watch-specific key, clay will use the default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.