Allow changing installation prefix #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to change where
make installinstalls files.This is useful in NixOS where the correct installation path is for example
/nix/store/y0r97v3g7amkaw0rcvkmxnj6al02q064-qjournalctl-0.6.4instead of/usr.Qjournalctl's package definition in nixpkgs modifies
qjournalctl.pro, replacing/usrwith correct path here:https://github.com/NixOS/nixpkgs/blob/bf3287dac860542719fe7554e21e686108716879/pkgs/applications/system/qjournalctl/default.nix#L24
However, with this change that patching phase is not needed. Package's configure phase is already calling
qmakewithPREFIXprovided as argument. It is just matter of using the variable in the project file. This makes it easier to hack qjournalctl's code in NixOS as the project file does not need to be changed.Modified also
autogen.shand added readme instructions in case defining PREFIX is useful outside of NixOS usage.