Conversation
egegunes
reviewed
Feb 23, 2026
egegunes
requested changes
Feb 24, 2026
pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgrescluster_types.go
Show resolved
Hide resolved
hors
requested changes
Feb 24, 2026
egegunes
previously approved these changes
Mar 3, 2026
hors
previously approved these changes
Mar 3, 2026
nmarukovich
previously approved these changes
Mar 4, 2026
Collaborator
commit: a74d00e |
egegunes
reviewed
Mar 5, 2026
Comment on lines
+12
to
+15
| if [[ $OPENSHIFT ]]; then | ||
| echo "Skipping LDAP-TLS test on OpenShift" | ||
| exit 1 | ||
| fi |
Contributor
There was a problem hiding this comment.
this will lead to unnecessary retries but also exit 0 will make the test continue. i wonder how can we improve this kind of situations where need to skip tests on jenkins? @jvpasinatto any ideas?
Collaborator
There was a problem hiding this comment.
I think we do not have many choices. We need to use exit 0
egegunes
approved these changes
Mar 5, 2026
mayankshah1607
approved these changes
Mar 5, 2026
nmarukovich
approved these changes
Mar 5, 2026
hors
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://perconadev.atlassian.net/browse/K8SPG-683
CHANGE DESCRIPTION
Problem:
Adds support for configuring PostgreSQL LDAP authentication over TLS (ldaps) in PerconaPG clusters.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability