fix: key Tia worker partials per process to survive batch recycling - #1782
Open
lazerg wants to merge 1 commit into
Open
fix: key Tia worker partials per process to survive batch recycling#1782lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
When recording a TIA graph with
--tia --parallel --max-batch-size=N, most of the dependency graph is silently dropped.Tia::flushWorkerPartial()keys each worker's edge partial byworkerToken(), which prefers ParaTest'sTEST_TOKEN.TEST_TOKENis stable per worker slot, not per process, so when ParaTest recycles the process in a slot every N tests, each new process writes its partial to the same filename and clobbers the batches its predecessors recorded in that slot. The parent's merge only ever sees the last batch per slot, sograph.jsonends up with edges for a fraction of the suite and later--tiaruns re-execute almost everything as uncached.workerToken()now prefersUNIQUE_TEST_TOKEN, which ParaTest sets uniquely per worker process, and falls back toTEST_TOKEN/PID as before. The parent already merges every file matching the prefix, so one partial per process merges cleanly with no other changes. The same keying is shared by the results and no-driver partials, which are fixed by the same change.Related:
Fixes #1778