Add nth-of-type support, optional args order#214
Closed
zgreen wants to merge 12 commits intopeterramsing:masterfrom
Closed
Add nth-of-type support, optional args order#214zgreen wants to merge 12 commits intopeterramsing:masterfrom
zgreen wants to merge 12 commits intopeterramsing:masterfrom
Conversation
added 9 commits
November 30, 2015 21:22
Author
|
Will look into that Travis error. |
Owner
|
This looks awesome! Would you mind submitting a PR against the 6.7.0 branch? I can do it as well if you'd like. |
Author
|
No problem, just submitted. |
Owner
|
Thanks! I just got to work but I'll follow up with #216 later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things primarily:
nth-of-typesupport.lost-columnandlost-rowcan now be passed optionally/in any order.All current tests passing and I think it would probably be prudent to add more, but I wanted to submit this so that folks could have a look at it.