fix: paginate tool listing#248
Open
haosenwang1018 wants to merge 1 commit intophilschmid:mainfrom
Open
Conversation
Signed-off-by: haosenwang1018 <haosenwang1018@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nextCursorwhen listing MCP toolsProblem
Issue #206 reports that
mcp-clisilently drops tools from servers that paginatetools/listresponses. The current client only requests the first page.Fix
listTools()now keeps requesting tool pages untilnextCursoris exhausted, then returns the full aggregated list. This makeslist,grep,info, and the tool existence checks incallwork correctly with paginated MCP servers.Fixes #206
Validation
git diff --checknpx tsc --noEmitbun test tests/client.test.tsbun test tests/config.test.tsbun test tests/output.test.tsnpx @biomejs/biome check src/client.ts tests/client.test.ts