ext/openssl: avoid redundant input/output copies.#21926
Open
devnexen wants to merge 1 commit intophp:masterfrom
Open
ext/openssl: avoid redundant input/output copies.#21926devnexen wants to merge 1 commit intophp:masterfrom
devnexen wants to merge 1 commit intophp:masterfrom
Conversation
Switch the PKCS12/PKCS7/CMS readers to BIO_new_mem_buf so the parsers work on the PHP string directly. Also adds a missing NULL check in pkcs12_read. openssl_seal/openssl_open write straight into a zend_string instead of an emalloc buffer that gets copied via zend_string_init.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the PKCS12/PKCS7/CMS readers to BIO_new_mem_buf so the parsers work on the PHP string directly. Also adds a missing NULL check in pkcs12_read.
openssl_seal/openssl_open write straight into a zend_string instead of an emalloc buffer that gets copied via zend_string_init.