Fix registering a service from another sub-package#1317
Open
wouterj wants to merge 2 commits intophpDocumentor:mainfrom
Open
Fix registering a service from another sub-package#1317wouterj wants to merge 2 commits intophpDocumentor:mainfrom
wouterj wants to merge 2 commits intophpDocumentor:mainfrom
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guides-restructured-text package registered a service for a class living in the guides-graphs package. This creates an invalid service when using the package without guides-graphs.
The Symfony DI container is more strict in newer versions, causing this invalid service to create a compile time error.
The UML directive is already correctly registered by the guides-graphs package:
guides/packages/guides-graphs/resources/config/guides-graphs.php
Lines 23 to 24 in 6a008ff