Allow MicCSSEntity to overwrite existing file #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When telling its CSS file to copy itself to a destination directory, MicCSSEntity was giving its MicCSSFile the full path, including the file basename. If the file alredy existed at that path, the MicCSSFile was attempting to delete the full path and appending the basename again, leading to an infinite loop. This completely moves the responsibility for knowing the basename to MicCSSFile.
Contributor
|
Thanks a lot andrzej! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When telling its CSS file to copy itself to a destination directory, MicCSSEntity was giving its MicCSSFile the full path, including the file basename. If the file alredy existed at that path, the MicCSSFile was attempting to delete the full path and appending the basename again, leading to an infinite loop.
This completely moves the responsibility for knowing the basename to MicCSSFile.
A proposal to fix #982 and #618