wip

[hongyunyan]

What problem does this PR solve?

Issue Number: close #3974

What is changed and how it works?

This pull request refactors the handling of dispatcher exclusions within the system, primarily by deprecating the ExcludeDispatcherId field in heartbeat responses. The changes ensure that the writerDispatcher is consistently included in barrier events for database-level influence types, streamlining the logic for dispatcher management. These modifications also account for rolling upgrade compatibility, preventing issues with older dispatcher managers that might still expect the ExcludeDispatcherId field.

Highlights

• Deprecation of ExcludeDispatcherId: The ExcludeDispatcherId field in heartbeat responses is being deprecated. The system will no longer filter dispatchers based on this ID in the DispatcherManager.
• Inclusion of Writer Dispatcher: The writerDispatcher is now explicitly included in barrier events for database-level influence types, where it was previously excluded. This ensures all relevant dispatchers receive pass actions.
• Rolling Upgrade Compatibility: Changes were made to newPassActionMessage to set ExcludeDispatcherId to an empty ID for non-normal influence types, maintaining compatibility during rolling upgrades for older dispatcher managers.
• New Test Case: A new unit test TestSendPassActionTypeDBIncludesWriterNode has been added to verify the correct behavior of including the writer node in DB type pass actions.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3aceshowhand for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @hongyunyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of dispatcher exclusions within the system, primarily by deprecating the ExcludeDispatcherId field in heartbeat responses. The changes ensure that the writerDispatcher is consistently included in barrier events for database-level influence types, streamlining the logic for dispatcher management. These modifications also account for rolling upgrade compatibility, preventing issues with older dispatcher managers that might still expect the ExcludeDispatcherId field.

Highlights

• Deprecation of ExcludeDispatcherId: The ExcludeDispatcherId field in heartbeat responses is being deprecated. The system will no longer filter dispatchers based on this ID in the DispatcherManager.
• Inclusion of Writer Dispatcher: The writerDispatcher is now explicitly included in barrier events for database-level influence types, where it was previously excluded. This ensures all relevant dispatchers receive pass actions.
• Rolling Upgrade Compatibility: Changes were made to newPassActionMessage to set ExcludeDispatcherId to an empty ID for non-normal influence types, maintaining compatibility during rolling upgrades for older dispatcher managers.
• New Test Case: A new unit test TestSendPassActionTypeDBIncludesWriterNode has been added to verify the correct behavior of including the writer node in DB type pass actions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[hongyunyan]

/help

[hongyunyan]

/test help

[ti-chi-bot]

@hongyunyan: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-build

/test pull-cdc-kafka-integration-heavy

/test pull-cdc-kafka-integration-light

/test pull-cdc-mysql-integration-heavy

/test pull-cdc-mysql-integration-light

/test pull-cdc-storage-integration-heavy

/test pull-cdc-storage-integration-light

/test pull-check

/test pull-error-log-review

/test pull-unit-test

The following commands are available to trigger optional jobs:

/test pull-build-next-gen

/test pull-cdc-kafka-integration-heavy-next-gen

/test pull-cdc-kafka-integration-light-next-gen

/test pull-cdc-mysql-integration-heavy-next-gen

/test pull-cdc-mysql-integration-light-next-gen

/test pull-cdc-pulsar-integration-light

/test pull-cdc-pulsar-integration-light-next-gen

/test pull-cdc-storage-integration-heavy-next-gen

/test pull-cdc-storage-integration-light-next-gen

/test pull-unit-test-next-gen

Use /test all to run the following jobs that were automatically triggered:

pull-build

pull-build-next-gen

pull-check

pull-error-log-review

pull-unit-test

pull-unit-test-next-gen

Details

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gemini-code-assist]

Code Review

This pull request appears to be a work-in-progress focused on deprecating ExcludeDispatcherId in heartbeat responses. The changes involve removing its usage in the dispatcher manager and updating message creation in the maintainer. While the intent is clear, the current implementation seems to introduce issues where the writer dispatcher might incorrectly receive a Pass action for Normal and All influence types. I've provided specific comments and suggestions to address these potential bugs. Additionally, there's an unused variable that should be cleaned up. The new test case for the DB influence type is a good addition.

I am having trouble creating individual review comments. Click here to see my feedback.

maintainer/barrier_event.go (36)

The variable logExcludeDispatcherIDDeprecatedOnce is declared but never used. It should either be used to log a deprecation warning for ExcludeDispatcherId once, or removed if it's not needed.

[hongyunyan]

/test pull-cdc-mysql-integration-heavy

[hongyunyan]

/test pull-cdc-kafka-integration-heavy

[ti-chi-bot]

@hongyunyan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-unit-test-next-gen	d3534ea	link	false	/test pull-unit-test-next-gen
pull-unit-test	d3534ea	link	true	/test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.