Add SILK noise shape primitives#163
Merged
Merged
Conversation
Co-authored-by: François Allais <francois.allais@hotmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 89.27% 89.31% +0.04%
==========================================
Files 44 46 +2
Lines 8783 8817 +34
==========================================
+ Hits 7841 7875 +34
Misses 707 707
Partials 235 235
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FrantaBOT
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds two small standalone pieces:
noise_shape.go:sigmoidandwarpedAutocorrelationFLP— autocorrelation through a chain of first-order all-pass warping sections, used by the noise-shaping analysis stage.control_snr.go:controlSNR— target residual-quantizer SNR as a function of bitrate, plus the NB/MB/WB bitrate→SNR lookup tablesported from
SigProc_FLP.h,warped_autocorrelation_FLP.c, andcontrol_SNR.c.control_snr.godidn't have a test upstream, so I wrote one from scratch (low-rate floor, first reachable table bucket, high-rate clamp, and the 10ms subframe-count rate offset)this is a smaller slice of noise shaping than originally planned —
noise_shape_analysis.go(the actualsilk_noise_shape_analysis_FLP/silk_process_gains_FLPorchestration) turned out to be entirely*Encodermethods with no separable pure logic underneath, so the whole file — plus a couple of small helpers only those two functions use — moves to the piece that introduces the encoder struct instead