Conversation
Update lint scripts and CI configs.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (20.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 77.74% 77.40% -0.35%
==========================================
Files 22 22
Lines 2022 2031 +9
==========================================
Hits 1572 1572
- Misses 354 362 +8
- Partials 96 97 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
transport_layer_cc.go
Outdated
There was a problem hiding this comment.
we can just add //nolint:gosec // G115 we validate that there is no overflow here or something similar. since we already validate it in this block, but the linter isn't smart enough to detect that.
|
@lanc07 thank you so much allan, let me know you want me to help / continue this. we mostly need to check if we validate boundaries and don't have any overflows and add nolint. |
3f1a33b to
217a364
Compare
- Also, add nolint for G115 warnings.
217a364 to
6adf286
Compare
|
Thank you Allan, sorry i didn't see that you fixed the issues. |
Update lint scripts and CI configs.