Skip to content

Update CI configs to v0.12.1#218

Merged
JoTurk merged 2 commits intomasterfrom
sync-assets-v0.12.1
Mar 29, 2026
Merged

Update CI configs to v0.12.1#218
JoTurk merged 2 commits intomasterfrom
sync-assets-v0.12.1

Conversation

@pionbot
Copy link
Copy Markdown
Contributor

@pionbot pionbot commented Mar 5, 2026

Update lint scripts and CI configs.

Update lint scripts and CI configs.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.40%. Comparing base (06eaa85) to head (6adf286).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
rfc8888.go 5.88% 16 Missing ⚠️
transport_layer_cc.go 30.00% 14 Missing ⚠️
sender_report.go 0.00% 10 Missing ⚠️
receiver_report.go 0.00% 6 Missing ⚠️
transport_layer_nack.go 0.00% 6 Missing ⚠️
goodbye.go 0.00% 5 Missing ⚠️
full_intra_request.go 0.00% 4 Missing ⚠️
source_description.go 0.00% 4 Missing ⚠️
receiver_estimated_maximum_bitrate.go 66.66% 1 Missing and 1 partial ⚠️
packet_buffer.go 83.33% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (20.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   77.74%   77.40%   -0.35%     
==========================================
  Files          22       22              
  Lines        2022     2031       +9     
==========================================
  Hits         1572     1572              
- Misses        354      362       +8     
- Partials       96       97       +1     
Flag Coverage Δ
go 77.40% <20.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lanc07 lanc07 requested review from JoTurk and Juliapixel March 19, 2026 11:37
Copy link
Copy Markdown
Member

@JoTurk JoTurk Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just add //nolint:gosec // G115 we validate that there is no overflow here or something similar. since we already validate it in this block, but the linter isn't smart enough to detect that.

@JoTurk
Copy link
Copy Markdown
Member

JoTurk commented Mar 22, 2026

@lanc07 thank you so much allan, let me know you want me to help / continue this. we mostly need to check if we validate boundaries and don't have any overflows and add nolint.

@lanc07 lanc07 requested a review from JoTurk March 23, 2026 00:08
@JoTurk JoTurk force-pushed the sync-assets-v0.12.1 branch from 3f1a33b to 217a364 Compare March 29, 2026 16:42
- Also, add nolint for G115 warnings.
@JoTurk JoTurk force-pushed the sync-assets-v0.12.1 branch from 217a364 to 6adf286 Compare March 29, 2026 16:50
@JoTurk JoTurk merged commit 2a11841 into master Mar 29, 2026
18 of 19 checks passed
@JoTurk JoTurk deleted the sync-assets-v0.12.1 branch March 29, 2026 16:51
@JoTurk
Copy link
Copy Markdown
Member

JoTurk commented Mar 29, 2026

Thank you Allan, sorry i didn't see that you fixed the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants