fix(cloudrun): guard against nil panics in manifest parsing, client options, and cache type assertion#6562
Open
mihir-dixit2k27 wants to merge 2 commits intopipe-cd:masterfrom
Open
Conversation
…ptions, and cache type assertion - ParseServiceManifest: return error when YAML unmarshal produces nil Object map (empty/nil input) - ParseRevisionManifest: same nil Object guard - client.List/ListRevisions: default to empty options struct when nil is passed - ServiceManifestCache.Get: use comma-ok type assertion to prevent panic on cache type mismatch Signed-off-by: Mihir Dixit <dixitmihir1@gmail.com>
mihir-dixit2k27
force-pushed
the
fix/cloudrun-provider-panics
branch
from
3ca77f3 to
1eb5edf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes four nil-panic risks in
pkg/app/piped/platformprovider/cloudrun/:ParseServiceManifest—sigs.k8s.io/yamlunmarshals empty input without error but leaves
obj.Objectnil,panicking on any subsequent field access. Added nil Object guard.
ParseRevisionManifest— same issue, same fix.List/ListRevisionsdereferenceoptions.Limitimmediately — nil options panics. Default to empty struct instead.
item.(ServiceManifest)assertion panics on typemismatch. Replaced with comma-ok pattern + structured error log.
Why we need it
All four are silent — only surface in production under specific inputs
(empty config file, nil options, cache collision). Fixes are minimal
and non-breaking; valid inputs follow identical code paths as before.
Does this PR introduce a user-facing change?
service.yamlnow returns a clearerror instead of panicking. All other behavior unchanged.