Skip to content

ci: add automated thank you workflow for merged PRs#6569

Open
shivansh-gohem wants to merge 4 commits intopipe-cd:masterfrom
shivansh-gohem:feat/automated-thank-you
Open

ci: add automated thank you workflow for merged PRs#6569
shivansh-gohem wants to merge 4 commits intopipe-cd:masterfrom
shivansh-gohem:feat/automated-thank-you

Conversation

@shivansh-gohem
Copy link
Contributor

This PR introduces a new GitHub Action workflow to automate contributor appreciation. It listens for merged Pull Requests and uses the GitHub Search API to determine if the author is a first-time contributor or a returning contributor, leaving a customized thank-you comment accordingly

@Ayushmore1214
Copy link
Contributor

@shivansh-gohem Dropped some suggestions!

@shivansh-gohem
Copy link
Contributor Author

Hi @Ayushmore1214, thank you again for the great feedback! All requested changes have been addressed and pushed

@shivansh-gohem
Copy link
Contributor Author

shivansh-gohem commented Mar 9, 2026

I ran a test on my fork, and the maintainer-skip logic worked perfectly! Since I am the OWNER of my fork, the bot correctly identified my association and gracefully exited without commenting. I've attached the screenshot of the Action logs below as proof
Screenshot 2026-03-09 213056

@Ayushmore1214
Copy link
Contributor

@Warashi Since the token permission blocks us, parsing MAINTAINERS.md is definitely the cleanest workaround

@Warashi
Copy link
Member

Warashi commented Mar 14, 2026

@Ayushmore1214 It works, but it's not recommended since MAINTAINERS.md is intended for humans, not machines.

@Warashi
Copy link
Member

Warashi commented Mar 14, 2026

IMO, to implement this feature stably, we must manage the maintainer list in a machine-readable format, such as JSON.

@Ayushmore1214
Copy link
Contributor

@Warashi 100% agree JSON file works!

@shivansh-gohem
Copy link
Contributor Author

great catch @Warashi! I didn't realize the default token was blind to private members. I totally agree that a machine-readable format is the way to go. I'll push an update shortly that adds a MAINTAINERS.json file and updates the script to read from it using Node's fs module!

Signed-off-by: Shivansh Sahu <sahushivansh142@gmail.com>
Signed-off-by: Shivansh Sahu <sahushivansh142@gmail.com>
…ction

Signed-off-by: Shivansh Sahu <sahushivansh142@gmail.com>
…ction

Signed-off-by: Shivansh Sahu <sahushivansh142@gmail.com>
@shivansh-gohem shivansh-gohem force-pushed the feat/automated-thank-you branch from 60ba00a to c3ef409 Compare March 14, 2026 16:48
@shivansh-gohem
Copy link
Contributor Author

@Warashi @Ayushmore1214 i have adressed the issue you raised !! please review!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants