bug(ecs): fix parseContainerImage to handle images with registry ports#6576
Open
zyzzmohit wants to merge 1 commit intopipe-cd:masterfrom
Open
bug(ecs): fix parseContainerImage to handle images with registry ports#6576zyzzmohit wants to merge 1 commit intopipe-cd:masterfrom
zyzzmohit wants to merge 1 commit intopipe-cd:masterfrom
Conversation
Signed-off-by: zyzzmohit <mohitray949@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates parseContainerImage inside pkg/app/piped/platformprovider/ecs/task.go to use
strings.LastIndexfor separating the container image tag from the image name. It also adds unit tests to TestFindArtifactVersions for explicitly testing images with registry ports.Why we need it:
The previous implementation naively split the image string by
:to extract the image tag. If a user relies on a container image hosted in a registry that specifies a port (e.g.,localhost:5000/repo/image:tag), the function incorrectly split the URI, resulting in a misparsednameand an empty tag.This is the exact same architectural flaw recently identified and fixed in the Cloud Run provider (pkg/app/piped/platformprovider/cloudrun/servicemanifest.go). Because AWS ECS frequently utilizes custom Docker registries with ports, this is a necessary defensive fix mapping to real-world use cases.
Which issue(s) this PR fixes:
Fixes #6575
Does this PR introduce a user-facing change?:
Yes
my-registry.com:8443/app:v1).