This repository was archived by the owner on May 14, 2024. It is now read-only.
The resource part of the websocket-url not set correctly#169
Open
edeckers wants to merge 5 commits intopkyeck:masterfrom
Open
The resource part of the websocket-url not set correctly#169edeckers wants to merge 5 commits intopkyeck:masterfrom
edeckers wants to merge 5 commits intopkyeck:masterfrom
Conversation
…he value set via setResourceName, but always used the static value "socket.io" instead.
Added .podspec so this repository can be used in projects, until the official project is fixed.
|
I need this PR, I will use your code until this is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value that was set via setResourceName is not taken into account when generating the websocket url, and instead the static value "socket.io" is always used. This results in a redirect to the wrong url when socket.io is served in a subdirectory.