Skip to content

Clean up main graph route #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apata merged 1 commit into from
Apr 27, 2026
Merged

Clean up main graph route #6277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/plausible_web/controllers/stats_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ defmodule PlausibleWeb.StatsController do
Api.StatsController --) Browser: {"top_stats": [...]}
Note left of Browser: TopStats.render()

Browser -) Api.StatsController: GET /api/stats/mydomain.com/main-graph
Api.StatsController --) Browser: [{"plot": [...], "labels": [...]}, ...]
Note left of Browser: VisitorGraph.render()

Browser -) Api.StatsController: GET /api/stats/mydomain.com/sources
Api.StatsController --) Browser: [{"name": "Google", "visitors": 292150}, ...]
Note left of Browser: Sources.render()
Expand Down
1 change: 0 additions & 1 deletion lib/plausible_web/router.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ defmodule PlausibleWeb.Router do
scope private: %{allow_consolidated_views: true} do
post "/:domain/query", StatsController, :query
get "/:domain/current-visitors", StatsController, :current_visitors
get "/:domain/main-graph", StatsController, :main_graph
get "/:domain/sources", StatsController, :sources
get "/:domain/channels", StatsController, :channels
get "/:domain/utm_mediums", StatsController, :utm_mediums
Expand Down
32 changes: 15 additions & 17 deletions test/plausible_web/controllers/api/stats_controller/authorization_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ defmodule PlausibleWeb.Api.StatsController.AuthorizationTest do
describe "API authorization - as anonymous user" do
test "returns 404 for a site that doesn't exist", %{conn: conn} do
conn = init_session(conn)
conn = get(conn, "/api/stats/fake-site.com/main-graph")

conn =
post(conn, "/api/stats/fake-site.com/query", %{})

assert json_response(conn, 404) == %{
"error" => "Site does not exist or user does not have sufficient access."
Expand All @@ -22,7 +24,9 @@ defmodule PlausibleWeb.Api.StatsController.AuthorizationTest do
test "returns 404 for private site", %{conn: conn} do
conn = init_session(conn)
site = insert(:site, public: false)
conn = get(conn, "/api/stats/#{site.domain}/main-graph")

conn =
post(conn, "/api/stats/#{site.domain}/query", %{})

assert json_response(conn, 404) == %{
"error" => "Site does not exist or user does not have sufficient access."
Expand All @@ -34,10 +38,7 @@ defmodule PlausibleWeb.Api.StatsController.AuthorizationTest do
site = insert(:site, public: true)

conn =
post(conn, "/api/stats/#{site.domain}/query", %{
"date_range" => "day",
"metrics" => ["visitors"]
})
query_visitors(conn, site, [])

assert %{"results" => _} = json_response(conn, 200)
end
Expand Down Expand Up @@ -183,7 +184,9 @@ defmodule PlausibleWeb.Api.StatsController.AuthorizationTest do

test "returns 404 for a site that doesn't exist", %{conn: conn} do
conn = init_session(conn)
conn = get(conn, "/api/stats/fake-site.com/main-graph/")

conn =
post(conn, "/api/stats/fake-site.com/query", %{})

assert json_response(conn, 404) == %{
"error" => "Site does not exist or user does not have sufficient access."
Expand All @@ -192,7 +195,9 @@ defmodule PlausibleWeb.Api.StatsController.AuthorizationTest do

test "returns 404 when user does not have access to site", %{conn: conn} do
site = new_site()
conn = get(conn, "/api/stats/#{site.domain}/main-graph")

conn =
post(conn, "/api/stats/#{site.domain}/query", %{})

assert json_response(conn, 404) == %{
"error" => "Site does not exist or user does not have sufficient access."
Expand All @@ -203,22 +208,15 @@ defmodule PlausibleWeb.Api.StatsController.AuthorizationTest do
site = new_site(public: true)

conn =
post(conn, "/api/stats/#{site.domain}/query", %{
"date_range" => "day",
"metrics" => ["visitors"]
})
query_visitors(conn, site, [])

assert %{"results" => _} = json_response(conn, 200)
end

test "returns stats for a private site that the user owns", %{conn: conn, user: user} do
site = new_site(public: false, owner: user)

conn =
post(conn, "/api/stats/#{site.domain}/query", %{
"date_range" => "day",
"metrics" => ["visitors"]
})
conn = query_visitors(conn, site, [])

assert %{"results" => _} = json_response(conn, 200)
end
Expand Down
Loading