-
Notifications
You must be signed in to change notification settings - Fork 345
paragraph on normal order reduction in Untyped chapter #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh dear, have neither @wadler nor myself seen this PR for over a year? My apologies! |
|
I remembered it when I got to that point in the lecture. |
|
@wadler Could you comment? |
wadler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Peter! Sorry for the delay.
I agree that explaining "normal order reduction" is a good idea. I'm happy to accept lines 543-549 (except delete from "We can see ..." on 549) and lines 566-569.
Lines 551-556 duplicate what has already been said, in a form that doesn't align well with what came before, e.g. in progress there are three subcases for application, not two. Lines 558-562 consider two alternatives. In the first alternative, "introduces a chance of non-termination" requires more explanation for beginning students. In the second alternative, "have more opportunities" requires more explanation, and arguably is not correct. The second alternative includes various forms of optimal reduction, where the total number of reduction steps can be reduced by applying reduction "early" to the body of the lambda abstraction. That requires much more explanation, and is arguably not appropriate for this level of text. Rather than delay with further back-and-forth over these paragraphs, I recommend deleting them and accepting the rest.
6277a6e to
b70f56d
Compare
for more information, see https://pre-commit.ci
|
I trimmed the commit as per @wadler 's request |
|
@wadler Are you content with these changes now? Shall we merge this? |
wadler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The reduction strategy implemented by
progresscorresponds to the well-known normal order reduction.This PR proposes a few paragraph that discuss normal order reduction.