Fix AttributeError in orderObjects after deleting an object and restarting Zope#53
Fix AttributeError in orderObjects after deleting an object and restarting Zope#53
AttributeError in orderObjects after deleting an object and restarting Zope#53Conversation
|
@wesleybl thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
…estarting Zope Replace sorted() + _set_order() with an in-place sort, preserving the PersistentList.
mauritsvanrees
left a comment
There was a problem hiding this comment.
On this maintenance branch, please keep the _set_order method, even though we won't call it anymore. Someone may have subclassed this and relies on the existence of this method.
Adding a warnings.warn within the method would be nice.
Possibly even add a fix:
if not isinstance(value, PersistentList):
value = PersistentList(value)
|
Also, I see you started another branch with [Update: two extra commits] |
38f3d4b to
111b475
Compare
may override or call it.
Backport of #50 to plone.folder 4.x