PR : Fix responsible group visibility after injection#607
Open
Neu-Maximilian wants to merge 2 commits intopluginsGLPI:mainfrom
Open
PR : Fix responsible group visibility after injection#607Neu-Maximilian wants to merge 2 commits intopluginsGLPI:mainfrom
Neu-Maximilian wants to merge 2 commits intopluginsGLPI:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses GLPI equipment “responsible group” visibility after DataInjection imports (#606) by normalizing injected group fields into the relation payload keys GLPI expects during save flows.
Changes:
- Normalize
groups_id,groups_id_normal, andgroups_id_techinto_groups_id/_groups_id_techarrays during injection. - Preserve technical-group handling via key-based and metadata-based detection.
- Add an Unreleased changelog entry describing the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
inc/commoninjectionlib.class.php |
Normalizes injected group assignment fields to GLPI’s expected relation payload keys to keep groups UI-visible after import. |
CHANGELOG.md |
Documents the fix under the Unreleased “Fixed” section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
groups_id,groups_id_normal, andgroups_id_techto the GLPI relation payload keys expected by equipment save flows_groups_id_tech