Open
Conversation
added spanish compiled translation
Owner
|
@ziafazal @e0d Can you please clarify as to the reason for including compiled files in the repo? That seems odd... Shouldn't these be built as part of the build/install process? If not, I would still be hesitant to merge the outputs of a black box build process. There ought to be a Makefile, script, or similar (some way to rebuild them for new persons to the repo, unfamiliar with edX' i18n pipeline). |
Collaborator
Author
|
@pmitros Xblocks have to provide compiled versions of translations for themselves since current build process does not generate/compile translations for XBlocks. XBlock developer can run this gettext command in base directory of XBlock to compile translations |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has compiled translations.
@pmitros Could you please merge and create a new release(1.2)?