-
-
Notifications
You must be signed in to change notification settings - Fork 700
feat(utils): deprecate atomFamily in jotai/utils (migrate to jotai-family)
#3187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/GQJQ68CBT |
See documentations for usage instructions.
dai-shi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add runtime dev-only one-time deprecation warning?
Use didWarnDeprecation flag like https://github.com/pmndrs/zustand/blob/adce5e6f2adff35994b8b9c9d04aa6a6dbee5e77/src/middleware/devtools.ts#L277
6f1756e to
edb3b46
Compare
dai-shi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jotai/utils (migrate to jotai-family)
jotai/utils (migrate to jotai-family)jotai/utils (migrate to jotai-family)
Summary
Check List
pnpm run fixfor formatting and linting code and docs