fix: preserve walrus comments across formatter passes#520
Open
msaule wants to merge 1 commit into
Open
Conversation
msaule
marked this pull request as ready for review
July 22, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #512.
Summary
Preserve an own-line comment between
:=and its RHS so that formatting is idempotent. Comment-free walrus line breaks and end-of-line comments retain Air's existing compact canonical output.Root cause
Walrus formatting intentionally flattens ordinary line breaks. When the RHS instead starts with an own-line comment, flattening changes the comment's syntactic position; a second pass then moves it after the RHS.
Validation
cargo test -p air_r_formattercargo test --workspace --exclude lspcargo clippy -p air_r_formatter --all-targets