Conversation
🦋 Changeset detectedLatest commit: 2945605 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
force-pushed
the
fix-parameter-logging
branch
from
89563f5 to
34d2eb5
Compare
Sleepful
approved these changes
Apr 9, 2026
Contributor
Sleepful
left a comment
Sleepful
left a comment
There was a problem hiding this comment.
LGTM -- just one comment to address (not blocking on it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #520.
The error data included the entire
StorageCheckpointUpdate, which internally included references to the underlying storage implementation. This pollutes the logs with the implementation and driver details, to the point where the JSON log parsers may not function properly anymore.This changes it to only include the checkpoint number.
This also adds filtering to the logger to make sure we can't log these storage classes directly.