Conversation
LucDeCaf
approved these changes
Apr 14, 2026
Contributor
LucDeCaf
left a comment
LucDeCaf
left a comment
There was a problem hiding this comment.
Out of curiosity, why were we copying the worker file to itself if it's (seemingly) unnecessary? Just curious :)
Contributor
Author
Being to lazy to look it up right now, I think it's probably because we used to emit the worker file in another directory first. I probably changed that at some point of the refactoring and forgot to look at the second half of the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To compile the web worker, we run
dart compile js -o packages/powersync/assets/powersync_db.worker.js. Afterwards, we used to copy the emitted JavaScript file to its own path. This is harmless on macOS, but causes the resultingpowersync_db.worker.jsfile to be empty on Linux. That in turn caused release automation failures, I had to manually upload the worker file for the last releases.This PR should fix the release process and ensure we run tests with workers available.