Skip to content

Fix #448 and also allow to change a muted note to a real note#557

Open
sbonaime wants to merge 7 commits into
powertab:masterfrom
sbonaime:master
Open

Fix #448 and also allow to change a muted note to a real note#557
sbonaime wants to merge 7 commits into
powertab:masterfrom
sbonaime:master

Conversation

@sbonaime

Copy link
Copy Markdown
Contributor

Description of Change(s)

Add the option to directly insert a new muted note without requiring a number to be entered first.
Add the option to change a muted note to a regular note with some numbers

Fixes Issue(s)

#448

Copilot AI review requested due to automatic review settings April 28, 2026 22:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds improved tab-entry handling for muted notes (x) to address issue #448 and to allow converting a muted note into a fretted note by typing digits.

Changes:

  • Accept x key presses in the tab editor to insert a muted note directly when no note exists at the caret.
  • When typing a digit on a muted note, remove the Muted property and apply the typed fret number as a single undoable operation.
  • Keep “play note while editing” behavior for numeric entry while skipping playback for muted-note insertion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/app/powertabeditor.cpp
Comment thread source/app/powertabeditor.cpp Outdated
Comment thread source/app/powertabeditor.cpp Outdated
@sbonaime

Copy link
Copy Markdown
Contributor Author

I have to check Copilot reviews !

sbonaime and others added 4 commits April 29, 2026 21:32
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sbonaime

sbonaime commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@cameronwhite What do you think about this PR ?

@cameronwhite cameronwhite left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! I've been behind on reviewing PRs :)


if (mySettingsManager->getReadHandle()->get(
Settings::PlayNotesWhileEditing))
if (!isMutedKey)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment here is that the logic is a bit tricker to follow now:

  • if isMutedKey is true and there is already a note, it's not very clear that the intent is to fall through and not handle the key here. An early return might make that more clear?

Comment thread CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants