Increase test coverage for GDPR enforcement when COPPA in scope #3559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
added
do not merge
…ncrease-GDPR-test-coverage
…ncrease-GDPR-test-coverage
marki1an
requested changes
Nov 29, 2024
Collaborator
marki1an
left a comment
marki1an
left a comment
There was a problem hiding this comment.
All comments should be applied for auction spec
Comment on lines
726
to
727
| then: "Bidder should be called" | ||
| assert !bidder.getBidderRequests(ampStoredRequest.id) |
Collaborator
There was a problem hiding this comment.
then: "Bidder shouldn't be called"
| assert metrics[TEMPLATE_REQUEST_DISALLOWED_COUNT.getValue(ampStoredRequest, FETCH_BIDS)] == 1 | ||
|
|
||
| where: | ||
| requestCountry | accountCountry | requestIpV4 | requestIpV6 | header |
Collaborator
There was a problem hiding this comment.
Please use accountCountry and header in your test
| and: "Flush metrics" | ||
| flushMetrics(privacyPbsService) | ||
|
|
||
| when: "PBS processes auction request" |
Collaborator
There was a problem hiding this comment.
when: "PBS processes amp request"
Comment on lines
794
to
796
| and: "Save account config without eea countries into DB" | ||
| accountDao.save(getAccountWithGdpr(ampRequest.account, | ||
| new AccountGdprConfig(enabled: true, eeaCountries: PBSUtils.getRandomEnum(Country.class, [BULGARIA])))) |
Collaborator
There was a problem hiding this comment.
and: "Save account config with eea countries into DB"
def account = getAccountWithGdpr(ampRequest.account,
new AccountGdprConfig(enabled: true, eeaCountries: PBSUtils.getRandomEnum(Country.class, [BULGARIA])))
accountDao.save(account)
marki1an
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes? Are there any
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check