Privacy: Fix GDPR being ignored when in COPPA scope #3565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTMBNara
requested changes
Nov 21, 2024
Comment on lines
73
to
78
| final Set<String> bidders = results.stream() | ||
| .map(BidderPrivacyResult::getRequestBidder) | ||
| .collect(Collectors.toSet()); | ||
| final Map<String, User> bidderToUser = results.stream() | ||
| .map(result -> new AbstractMap.SimpleEntry<>(result.getRequestBidder(), result.getUser())) | ||
| .collect(HashMap::new, (map, entry) -> map.put(entry.getKey(), entry.getValue()), HashMap::putAll); |
Collaborator
There was a problem hiding this comment.
final Map<String, User> bidderToUser = results.stream()
.collect(Collectors.toMap(BidderPrivacyResult::getRequestBidder, BidderPrivacyResult::getUser));
final Set<String> bidders = bidderToUser.keySet();
CTMBNara
previously approved these changes
Nov 26, 2024
* Increase test coverage for GDPR enforcement when COPPA in scope
CTMBNara
approved these changes
Dec 4, 2024
sergseven
pushed a commit
to openx/prebid-server-java
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Right now GDPR processing is not happening both when the BidRequest.reg.ext.gdpr=1 is specified and when the request IP is from EEA.
🧪 Test plan
Unit tests, functional tests
🏎 Quality check