Skip to content

DXKulture: Remove Adapter#4434

Merged
CTMBNara merged 2 commits into
masterfrom
DXKulture-Remove-Adapter
Jul 23, 2026
Merged

DXKulture: Remove Adapter#4434
CTMBNara merged 2 commits into
masterfrom
DXKulture-Remove-Adapter

Conversation

@osulzhenko

@osulzhenko osulzhenko commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko
osulzhenko requested a review from CTMBNara March 20, 2026 12:00
@osulzhenko osulzhenko self-assigned this Mar 20, 2026
@osulzhenko osulzhenko linked an issue Mar 20, 2026 that may be closed by this pull request
Port PR from PBS-Go: DXKulture: Remove Adapter #4367
Closed
@osulzhenko osulzhenko assigned CTMBNara and unassigned osulzhenko Mar 20, 2026
Lightwood13
Lightwood13 previously approved these changes Jul 22, 2026
View reviewed changes
@osulzhenko
Merge branch 'refs/heads/master' into DXKulture-Remove-Adapter
7b306aa 
# Conflicts:
#	src/main/java/org/prebid/server/bidder/dxkulture/DxKultureBidder.java
#	src/main/java/org/prebid/server/spring/config/bidder/DxKultureBidderConfiguration.java
#	src/main/resources/bidder-config/dxkulture.yaml
#	src/test/resources/org/prebid/server/it/test-application.properties
@osulzhenko
osulzhenko force-pushed the DXKulture-Remove-Adapter branch from 5660b6c to 7b306aa Compare July 22, 2026 16:14
@And1sS
And1sS requested a review from Lightwood13 July 22, 2026 16:16
@CTMBNara
CTMBNara merged commit 16687ef into master Jul 23, 2026
7 of 8 checks passed
@CTMBNara
CTMBNara deleted the DXKulture-Remove-Adapter branch July 23, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@And1sS And1sS And1sS approved these changes
@CTMBNara CTMBNara CTMBNara approved these changes
@Lightwood13 Lightwood13 Awaiting requested review from Lightwood13

Assignees

@CTMBNara CTMBNara

Labels

do not port PBS 4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: DXKulture: Remove Adapter

4 participants

@osulzhenko @And1sS @Lightwood13 @CTMBNara