-
-
Notifications
You must be signed in to change notification settings - Fork 208
chore(CI): add tests for ESLint 8 #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a964de9 to
e5af184
Compare
|
If you rebase, a lot of this goes away. It looks like CI has passed successfully though, so it seems we're all v8 compliant. I'd prefer to avoid testing pre-release versions though if possible so I'm tempted to close this, and we can revisit once v8.0.0 is released. |
e5af184 to
6b17952
Compare
|
@BPScott Rebased onto I've also updated all ESLint-related dependencies to their latest versions. |
fea2628 to
04747df
Compare
04747df to
59910cb
Compare
59910cb to
85ee07b
Compare
|
Hey! When will be this new version published? It didn't trigger any new release since it was merged as a chore, but this should be a new minor adding compatibility for ESLint v8. |
|
This PR changed development-only dependencies and what we run in CI. There were no code changes required to support eslint 8, what is already published to npm is sufficient. |
|
Hi, I think you need to update peerDependencies as well. |
|
|
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
@graphql-eslint/eslint-plugin(Support ESLint 8.x graphql-hive/graphql-eslint#595)v2.3.0eslint-plugin-eslint-plugin(Support ESLint 8.x eslint-community/eslint-plugin-eslint-plugin#175)meta.hasSuggestionsproperty tometa-property-orderingrule eslint-community/eslint-plugin-eslint-plugin#119v4.0.0-0v4.0.0eslint-plugin-graphql(Support ESLint 8.x apollographql/eslint-plugin-graphql#310)eslint-plugin-node(Support ESLint 8.x mysticatea/eslint-plugin-node#294)vue-eslint-parserReleaseI wanted to update
eslint-config-prettier,eslint-plugin-eslint-plugin,eslint-plugin-node&vue-eslint-parserto their latest minor, but that would break CI on the older ESLint/Node versionsIf wanted, I can do it in this PR or make a second PR with all the breaking changes.
Edit: This can be done without a breaking change after #429 is merged
Closes #427