fix: prevent undefined in generated event search descriptions#1515
Open
slash-init wants to merge 5 commits into
Open
fix: prevent undefined in generated event search descriptions#1515slash-init wants to merge 5 commits into
slash-init wants to merge 5 commits into
Conversation
Member
|
Thanks @slash-init ! Possible to add to tests? Prevent regression / kind of a hard to spot problem |
Contributor
Author
|
Sure @ksen0, I'll add a regression test covering this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating the search index for events,
data.descriptionisundefinedbecause event pages do not define adescriptionfield. Concatenating it with the page content appends the literal string"undefined"to every generated event description.This PR uses a nullish fallback (
data.description ?? "") to prevent generating incorrect search index data.Fixes #1512